add partition key marker for Athena and Presto schemas#2764
Conversation
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
jezdez
left a comment
jezdez
left a comment
There was a problem hiding this comment.
Sorry, but this needs another pass, adding back the docstring. Thank you, @alison985!
Otherwise this is good to go!
|
|
||
| # for athena and presto | ||
| def format_schema(results): | ||
| schema = {} |
There was a problem hiding this comment.
I'm sorry but the docstring changes from 17b9a0a didn't make it here, could you please add it?
| } | ||
|
|
||
|
|
||
| # for athena and presto |
There was a problem hiding this comment.
No need to have this extra code comment.
jezdez
left a comment
jezdez
left a comment
There was a problem hiding this comment.
Ah, quick update, I got feedback from Arik that adding a "[P]" to indicate the partition would not suffice on a UX design level and will need further follow-up. This PR is blocked while we get the needed feedback from the Redash frontend team.
2 participants
for: mozilla#430
ports the following upstream: https://github.com/mozilla/redash/pull/201/files
for previous code review see: #2655