@arikfr Hey there, @washort has ported various other Angular components but I thought it would make sense to start small first and see if you have feedback for the general setup that we can incorporate now. In other words, I consider this to be the first step of many and would appreciate if you or someone else from the Redash team could take a look at it. Cheers!

I think the tests are failing due to the JS dependencies being different from master. Could a maintainer try CircleCI's "run without cache" option?

Actually I think it fails because of this:

Looks like ngcomponent needs lodash, and underscore doesn't cut it anymore. I'm cool with replacing underscore with lodash (should've done it long ago). Any idea if it's a drop-in replacement?

Aha, and I didn't notice this because we haven't pulled that into our fork yet. Fixed.

Looks like there may not be any dependencies on underscore other than dev dependencies and the direct uses in redash. Would you want those underscore usages converted to lodash for this PR?

Looks like there may not be any dependencies on underscore other than dev dependencies and the direct uses in redash. Would you want those underscore usages converted to lodash for this PR?

It's only being used by nomnom which is a dependency of a dependency of a dependency of a library Plot.ly is using :) I'm not sure it affects the build, because it looks like code that isn't used in the client.

The only thing we should probably do in this pull request is remove our requirements of underscore and underscore.string from package.json.

There's still one use of numberFormat from underscore.string present, but that doesn't depend on the rest of underscore so I left it. The rest of the usages I converted to lodash.

@washort don't you need to commit an updated package-lock.json file?

@washort never mind -- I did it myself (& updated some new files to use lodash instead of underscore).

Just one last question: did you had the chance to do some performance tests? Any noticeable implication of including react in the project?

I had a look using Chrome's "Lighthouse" audit tool and load/render times look like they're no more than 5% slower.

Merged. Let's get this party started. 🎉

https://discuss.redash.io/t/react-migration-an-experiment-with-less-di/2077

@arikfr ZOMG thank you!! 😍

@jezdez me? Let's thank @washort who does the heavy lifting here :-)

@arikfr That's true!

@washort: