Skip to content

upgrade to Celery 4.1.0#2529

Closed
mashrikt wants to merge 6 commits into
getredash:masterfrom
mashrikt:celery4
Closed

upgrade to Celery 4.1.0#2529
mashrikt wants to merge 6 commits into
getredash:masterfrom
mashrikt:celery4

Conversation

@mashrikt

@mashrikt mashrikt commented May 11, 2018

Copy link
Copy Markdown

This refers to #2517

I have reviewed Mozilla's both upgrade to Celery 3.1.25 and Celery 4.1.0.

I feel like I should give you guys a heads up regarding this.

@arikfr arikfr mentioned this pull request May 15, 2018
5 tasks
@atharvai

atharvai commented May 15, 2018

Copy link
Copy Markdown
Contributor

Hey thanks for working on this. I also worked on it in parallel as I didn't know you had started.

One thing maybe you can merge from my branch is the new env var config key: REDASH_WORKER_MAX_MEMORY_PER_CHILD
This is updated in two files:
https://github.com/getredash/redash/pull/2535/files#diff-324d42e08af87005833f42ea274a9abeR37
https://github.com/getredash/redash/pull/2535/files#diff-ad93995bb355251c02f87fc02db69351R53

my PR: #2535

I couldn't find your fork to create a PR from mine

@mashrikt

Copy link
Copy Markdown
Author

@atharvai I have created a PR from your celery_upgrade branch to my celery4 branch.
Would it be possible for you to fix the conflicts?

@mashrikt

Copy link
Copy Markdown
Author

@arikfr Review possible?

@RichardLitt

Copy link
Copy Markdown

@mashrikt We haven't forgotten. We'll review this as soon as we have some time. :)

@mashrikt

Copy link
Copy Markdown
Author

@RichardLitt Good to hear from you again!
Hope you're well.

@alison985

Copy link
Copy Markdown
Contributor

Please note there is a new issue with celery 4.1.0 because of an unpinned dependency in celery. see mozilla#405

@atharvai

atharvai commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Is there any more progress on this? I imagine we'll want to upgrade to celery==4.1.1 too because of issue Mozilla folks noticed.

@jezdez

jezdez commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

This was fixed in #2773. Thanks @mashrikt for your help!

@jezdez jezdez closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants