add dropdown association tests to query creation

Omer Lachish · Omer Lachish · commit ba0498bb91be · 2019-03-14T09:46:13.000+02:00
diff --git a/tests/handlers/test_queries.py b/tests/handlers/test_queries.py
@@ -239,6 +239,68 @@ def test_create_query(self):
         self.assertEquals(len(list(query.visualizations)), 1)
         self.assertTrue(query.is_draft)
 
+    def test_allows_association_with_authorized_dropdown_queries(self):
+        data_source = self.factory.create_data_source(group=self.factory.default_group)
+
+        other_query = self.factory.create_query(data_source=data_source)
+        db.session.add(other_query)
+
+        query_data = {
+            'name': 'Testing',
+            'query': 'SELECT 1',
+            'schedule': {"interval": "3600"},
+            'data_source_id': self.factory.data_source.id,
+            'options': {
+                'parameters': [{
+                    'type': 'query',
+                    'queryId': other_query.id
+                }]
+            }
+        }
+
+        rv = self.make_request('post', '/api/queries', data=query_data)
+        self.assertEqual(rv.status_code, 200)
+
+    def test_prevents_association_with_unauthorized_dropdown_queries(self):
+        other_data_source = self.factory.create_data_source(group=self.factory.create_group())
+        other_query = self.factory.create_query(data_source=other_data_source)
+        db.session.add(other_query)
+
+        my_data_source = self.factory.create_data_source(group=self.factory.create_group())
+
+        query_data = {
+            'name': 'Testing',
+            'query': 'SELECT 1',
+            'schedule': {"interval": "3600"},
+            'data_source_id': my_data_source.id,
+            'options': {
+                'parameters': [{
+                    'type': 'query',
+                    'queryId': other_query.id
+                }]
+            }
+        }
+
+        rv = self.make_request('post', '/api/queries', data=query_data)
+        self.assertEqual(rv.status_code, 403)
+
+    def test_prevents_association_with_non_existing_dropdown_queries(self):
+        query_data = {
+            'name': 'Testing',
+            'query': 'SELECT 1',
+            'schedule': {"interval": "3600"},
+            'data_source_id': self.factory.data_source.id,
+            'options': {
+                'parameters': [{
+                    'type': 'query',
+                    'queryId': 100000
+                }]
+            }
+        }
+
+        rv = self.make_request('post', '/api/queries', data=query_data)
+        self.assertEqual(rv.status_code, 400)
+
 
 class TestQueryArchiveResourceGet(BaseTestCase):
     def test_returns_queries(self):
