Repository navigation
fix: Support passing multiple extra settings via -e - #3631
Merged
justinmayer merged 1 commit intoNov 8, 2026
Merged
Conversation
Each -e / --extra-settings flag replaced the overrides collected by the previous one, so `pelican content -e A=1 -e B=2` only applied B. Merge the new KEY=VALUE pairs into the existing overrides instead; a later value for the same key still wins. Co-Authored-By: Claude Opus 5.5 <[email protected]>
justinmayer
changed the title
-e
justinmayer
approved these changes
Nov 8, 2026
justinmayer
left a comment
justinmayer
left a comment
Member
There was a problem hiding this comment.
Thank you, Wei Lun, for the enhancement! 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
-e/--extra-settingsmore than once only keeps the settings from the last flag. For example:prints the default
SITENAME, because the second-ereplaced the dict built by the first one. This also bites the generatedtasks.py:livereloadalready passes-e CACHE_CONTENT=true LOAD_CONTENT_CACHE=true, so adding your own-e ...through the pass-through arguments silently drops those two.ParseOverridesnow starts from the overrides already on the namespace and adds the new pairs to them, so repeated flags add up. If the same key is given twice, the later value still wins. I added a test totest_cli.pythat fails onmainand passes with this change.Pull Request Checklist
I used Claude Code to write this change.