Fix warning on PHP 7.4 #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.4 comes with a [warning](https://www.php.net/manual/de/migration74.incompatible.php#migration74.incompatible.core.non-array-access) when trying to access array offset on value of type int.
PierrickVoulet
added a commit
to googleads/google-ads-php
that referenced
this pull request
Jul 13, 2020
Some test failures are related to the implementation of the getopt-php project. Please wait for getopt-php/getopt-php#161 to be released before merging this PR.
Contributor
Author
|
Thank you for merging @tflori , is there any time estimate you could provide for the next release? |
Member
|
not yet, I can quickly create a new bugfix version |
Contributor
Author
I just noticed https://github.com/getopt-php/getopt-php/releases/tag/v3.4.0, thank you for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.4 comes with a warning when trying to access array offset on value of type int.
This is to fix one condition that generates some of these warnings.