Skip to content

Comments

ci: add support for building windows arm wheels#451

Merged
RazerM merged 2 commits intogetlogbook:developfrom
Greenie0701:develop
Sep 16, 2025
Merged

ci: add support for building windows arm wheels#451
RazerM merged 2 commits intogetlogbook:developfrom
Greenie0701:develop

Conversation

@Greenie0701
Copy link
Contributor

PR Description:

  • The adoption of Windows on ARM (WoA) devices is steadily increasing, yet many Python wheels are still not available for this platform.
  • GitHub Actions now offer native CI runners for Windows on ARM devices (windows-11-arm), enabling automated builds and testing.
  • Currently, official logbook Python wheels are not provided for Windows ARM64 and thus users/developers were facing difficulties using popular logbook library natively.
  • This PR introduces support for building logbook wheels on Windows ARM64, improving accessibility for developers and end users on this emerging platform.

@RazerM
Copy link
Collaborator

RazerM commented Sep 15, 2025

@Greenie0701 what is the value of platform.machine() on Windows ARM?

@RazerM
Copy link
Collaborator

RazerM commented Sep 15, 2025

I can't push to your branch, please apply this

diff --git a/.github/workflows/wheel-builder.yml b/.github/workflows/wheel-builder.yml
index ce66e27..cb1c3d0 100644
--- a/.github/workflows/wheel-builder.yml
+++ b/.github/workflows/wheel-builder.yml
@@ -47,7 +47,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-24.04, ubuntu-24.04-arm, windows-2025, windows-11-arm, macos-15]
+        os:
+          - ubuntu-24.04
+          - ubuntu-24.04-arm
+          - windows-2025
+          - windows-11-arm
+          - macos-15
 
     env:
       CIBW_BEFORE_ALL_LINUX: "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y"

@Greenie0701
Copy link
Contributor Author

@Greenie0701 what is the value of platform.machine() on Windows ARM?

Hi please find the results for platform.machine() on Windows ARM64:
image

@RazerM RazerM merged commit 8467d14 into getlogbook:develop Sep 16, 2025
55 of 56 checks passed
charliermarsh pushed a commit to astral-sh/uv that referenced this pull request Sep 17, 2025
…15921)

<!--
Thank you for contributing to uv! To help us out with reviewing, please
consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

I'm back again after #14041, this time for `win_arm64`. I [asked a
Windows on ARM
user](getlogbook/logbook#451 (comment))
what the value of `platform.machine()` is, and it's `ARM64`.

## Test Plan

Updated/added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants