feat: k-item skeleton theme
#7521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
feat/item-skelleton
branch
from
cf32a3c to
b7be107
Compare
12 tasks
Member
|
I like the skeletons a lot. I replaced the fallback dash for missing titles with a The dash does not really add any value and the skeletons look better when they are completely empty. We need the though to keep the min height of the title element. |
Member
Author
|
@bastianallgeier Fien to me :) We should just remove the one CSS rule then. Opacity not needed for the space. |
bastianallgeier
force-pushed
the
feat/item-skelleton
branch
from
34202fc to
a50283e
Compare
bastianallgeier
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to have an
k-itemtheme that can be used while an item is still being loaded as placeholder.I don't think this is necessarily the best design, but I could not come up with something better and am counting a little bit on @bastianallgeier to maybe have a better idea how it should look like.
Lab: https://sandbox.test/panel/lab/components/item/4_skeletons
Changelog
✨ Enhancements
-
sekeletontheme fork-itemFor review team