feat: Nested dialogs via history module #7519
Conversation
bastianallgeier
force-pushed
the
feat/dialog-history
branch
from
64f6971 to
9f0f506
Compare
|
I've added more lab examples to test the nested dialogs and realized that we need to fix the backdrop click for the dialogs.
Instead of arriving back at the first dialog, both dialogs are closed. When you try to open them again with the open button, nothing happens. |
|
@bastianallgeier is it the same for Drawers already? |
|
Could be that it happens there as well. Let me setup a test example in the lab as well. |
|
I've added an example and drawers don't have the same problem. Clicking on the backdrop correctly closes the currently open drawer, while keeping open parents. |
|
Ahhh, I found the missing piece. The dialog overlay needs the nested state in Panel.vue. From my perspective, everything works really well now. We could consider adding a breadcrumb to nested dialogs at a later point as well. But this is already so cool and will make quite a few missing features possible!! |
Changelog
Bringing the nested drawer support also to dialogs.
I think the new
closedlistener could be great for nested dialogs if a dialog opens another dialog to define in thatclosedlistener logic that needs to run when the 2nd dialog is closed and the first dialog is resumed. Thecloselistener does not always work for that as the state will still be of the 2nd dialog - so if it's any logic that needs to interact with the state of the 1st/original dialog, this needs to happen after the 2nd dialog has been closed.✨ Enhancements
panel.dialogfor nested dialogsclosedlistener for Panel dialogs and drawers that gets called after the dialog has been closed🐛 Bug fixes
For review team