Skip to content

refact: Use new collectors #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastianallgeier merged 4 commits into from
Jul 30, 2025
Merged

refact: Use new collectors #7435

bastianallgeier merged 4 commits into from
Jul 30, 2025

Conversation

@bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jul 30, 2025 •
edited
Loading

Merge first:

Changelog

♻️ Refactored

  • Use the new Collector classes in the files and pages section, as well as the users view.

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier requested a review from a team July 30, 2025 07:41
@bastianallgeier bastianallgeier changed the base branch from develop-minor to feat/collectors July 30, 2025 07:42
@bastianallgeier
Copy link
Member Author

bastianallgeier commented Jul 30, 2025

The failing unit test is driving me nuts. No matter which PHP version I use to run the tests locally, they all pass.

@bastianallgeier bastianallgeier force-pushed the refact/use-new-collectors branch 4 times, most recently from 39b3aed to 91abf95 Compare July 30, 2025 10:16
Base automatically changed from feat/collectors to develop-minor July 30, 2025 11:09
@bastianallgeier bastianallgeier force-pushed the refact/use-new-collectors branch 3 times, most recently from 42898c5 to 42363c1 Compare July 30, 2025 16:20
distantnative
distantnative previously approved these changes Jul 30, 2025
View reviewed changes
@bastianallgeier bastianallgeier force-pushed the refact/use-new-collectors branch 2 times, most recently from 354a3f7 to f8ba8c7 Compare July 30, 2025 16:47
@bastianallgeier bastianallgeier force-pushed the refact/use-new-collectors branch from f8ba8c7 to 44357b1 Compare July 30, 2025 16:47
@bastianallgeier bastianallgeier merged commit be382e2 into develop-minor Jul 30, 2025
14 checks passed
@bastianallgeier bastianallgeier deleted the refact/use-new-collectors branch July 30, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@distantnative distantnative distantnative left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bastianallgeier @distantnative