refact: Allow folders inside site/controllers
#7368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
App::controller()to also allow controllers noted in subfolders insidesite/controllers. This change enables us to add snippet and block controllers (https://feedback.getkirby.com/213) via a custom plugin then:With this plugin place, one can add a controller for e.g.
site/snippets/header.phptosite/controllers/snippets/header.php. And since blocks are also just snippets:site/controllers/snippets/blocks/video.php(though this currently just works if a custom blocks snippet has been added, not for the default ones).Choosing to go down the plugin path as it can have quite the performance impact if every snippet checks for the existence of a controller. Maybe you have also ideas how to improve that performance.
Changelog
Refactored
App::controller()to return controllers nested in subfolders insidesite/controllersReady?
For review team