Skip to content

fix: Hide placeholder on disabled string, number & textarea inputs #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastianallgeier merged 3 commits into from
Jul 11, 2025
Merged

fix: Hide placeholder on disabled string, number & textarea inputs #7360

bastianallgeier merged 3 commits into from
Jul 11, 2025

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Jul 10, 2025 •
edited by bastianallgeier
Loading

Description

Some inputs (date, text) would hide the placeholder when disabled, while others (e.g. email) would still show it. This PR fixes hiding the placeholder for all disabled string, number and texturea inputs.

Changelog

Fixes

  • Inputs: Hide placeholder text when disabled

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.1.0 milestone Jul 10, 2025
@distantnative distantnative requested a review from a team July 10, 2025 15:45
@distantnative distantnative self-assigned this Jul 10, 2025
@distantnative distantnative changed the title fix: Hide placeholder on disabled string inputs fix: Hide placeholder on disabled string, number & texture inputs Jul 11, 2025
@distantnative distantnative changed the title fix: Hide placeholder on disabled string, number & texture inputs fix: Hide placeholder on disabled string, number & textarea inputs Jul 11, 2025
@bastianallgeier
Copy link
Member

bastianallgeier commented Jul 11, 2025

I've added examples to the field setups in the sandbox

@bastianallgeier bastianallgeier merged commit 33702c0 into develop-minor Jul 11, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/string-input-disabled-placeholder branch July 11, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@distantnative @bastianallgeier