Skip to content

feat: panel.theme option for default theme #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
distantnative merged 1 commit into from
Jul 9, 2025
Merged

feat: panel.theme option for default theme #7341

distantnative merged 1 commit into from
Jul 9, 2025

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Jun 26, 2025 •
edited
Loading

Changelog

✨ Enhancements

  • New panel.theme config option to define the default Panel theme

Docs

panel.theme

Sets the default Panel theme that is used when the user has not set any custom setting in their account view. Support values: "light", "dark", "system" (default, matches the user's operating system)

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.0.1 milestone Jun 26, 2025
@distantnative distantnative self-assigned this Jun 26, 2025
@distantnative distantnative requested a review from a team June 26, 2025 17:34
@distantnative distantnative marked this pull request as ready for review June 26, 2025 17:34
afbora
afbora reviewed Jun 26, 2025
View reviewed changes
@distantnative distantnative force-pushed the feat/panel-theme-config-option branch from af34ce0 to 8ea0d18 Compare June 26, 2025 20:12
afbora
afbora reviewed Jun 26, 2025
View reviewed changes
@bastianallgeier
Copy link
Member

bastianallgeier commented Jun 27, 2025

Question: Do you think this change is small enough to be in a patch release or should we move it into 5.1?

@bastianallgeier bastianallgeier modified the milestones: 5.0.1, 5.0.2 Jul 3, 2025
@distantnative distantnative modified the milestones: 5.0.2, 5.1.0 Jul 6, 2025
@distantnative distantnative changed the base branch from develop-patch to develop-minor July 6, 2025 12:58
@distantnative distantnative force-pushed the feat/panel-theme-config-option branch from 8ea0d18 to b0ee483 Compare July 6, 2025 13:08
@distantnative
Copy link
Member Author

distantnative commented Jul 6, 2025

@bastianallgeier Moved it to 5.1

@distantnative distantnative changed the title fix: panel.theme option for default theme feat: panel.theme option for default theme Jul 6, 2025
@distantnative distantnative force-pushed the feat/panel-theme-config-option branch from b0ee483 to c24d782 Compare July 6, 2025 13:09
@distantnative distantnative requested review from a team and afbora July 8, 2025 13:11
@distantnative distantnative merged commit ef82d0f into develop-minor Jul 9, 2025
19 of 21 checks passed
@distantnative distantnative deleted the feat/panel-theme-config-option branch July 9, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afbora afbora afbora approved these changes

Assignees

@distantnative distantnative

Labels

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@distantnative @bastianallgeier @afbora