Skip to content

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Jun 15, 2025

Description

Summary

Moves the since tag information into its own simple section. This avoids displaying an empty description box if the component has no description but a since tag.

Screenshot 2025-07-08 at 22 09 31

@distantnative distantnative added this to the 5.0.0-rc.5 milestone Jun 15, 2025
@distantnative distantnative self-assigned this Jun 15, 2025
Base automatically changed from v5.0/refact/lab-docs-classes to v5/develop June 17, 2025 06:20
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positioning and sice of the since tag is still a bit off and it also shows up for components that don't have info about it

@distantnative
Copy link
Member Author

@bastianallgeier Not too happy with it either today... do you have any idea where to put it better?

@bastianallgeier
Copy link
Member

@distantnative maybe just a simple additional headline with the info below if since is defined? I don't think we need to be super fancy about it for now.

@distantnative distantnative modified the milestones: 5.0.0, 5.1.0 Jun 23, 2025
@distantnative distantnative changed the base branch from v5/develop to develop-minor June 24, 2025 21:19
@distantnative distantnative force-pushed the v5.0/refact/lab-docs-since branch from 8232a34 to 9460272 Compare July 8, 2025 13:10
@distantnative distantnative changed the title refact: Move since tag to title in Lab docs refact: Move since tag to own section in Lab docs Jul 8, 2025
@distantnative
Copy link
Member Author

@bastianallgeier Made it a very simple section

@distantnative distantnative marked this pull request as ready for review July 8, 2025 13:27
@bastianallgeier bastianallgeier merged commit 325dfd4 into develop-minor Jul 11, 2025
16 checks passed
@bastianallgeier bastianallgeier deleted the v5.0/refact/lab-docs-since branch July 11, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants