Refactor dialogs + drawers as classes #6967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
distantnative
force-pushed
the
v5/dialogs/1-backend-classes
branch
from
435529c to
76d283c
Compare
distantnative
force-pushed
the
v5/dialogs/1-backend-classes
branch
4 times, most recently
from
d5ee59a to
d767771
Compare
distantnative
force-pushed
the
v5/dialogs/1-backend-classes
branch
from
9b8a472 to
0ab2815
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo
LanguageVariable::language()#7379Panel\Ui\Componentfilternull, not[]#7384Summary of changes
Panel\Uiclasses for all dialogs and drawershandlerclosure that returns an object with::render()and::submit()methods that will be used then asload/submitevent actionsAdditional context
PageCreateDialogis a bit more complex and tricky and would be refactored in a separate step.Ready?
For review team