Describe the PR

The RegEx that was used for matching the parts of the query didn't account for nested method calls, so they only sometimes worked by accident.

E.g. this worked before:

object.method('test', object.method('test'))

But this didn't:

object.method('test', object.method('test').anotherMethod, 'test')

This is now fixed by always parsing method calls from the outside in and not from left to right. The only edge-case that doesn't work is an opening parenthesis inside a string:

object.method(object.method('('))

That's hard to fix however because it's hard to express that in a regular expression. However I think that this is not going to affect many queries in practice, so this PR is "a lot better than nothing". Maybe we'll find a solution for that last remaining edge-case in the future.

Related issues

• Fixes Query has unexpected behavior with add() #2511

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Fixed code style issues with CS fixer and composer fix
• Added in-code documentation (if needed)