More complex draft token with new content.salt option #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasbestle
reviewed
May 8, 2020
Co-authored-by: Lukas Bestle <[email protected]>
Co-authored-by: Lukas Bestle <[email protected]>
Co-authored-by: Lukas Bestle <[email protected]>
kraftner
approved these changes
May 11, 2020
kraftner
left a comment
kraftner
left a comment
There was a problem hiding this comment.
Looking great, thanks for the fast response @bastianallgeier
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR adds a salt to draft tokens, which are used for preview URLs. The salt can be configured with the new
content.saltoption.Ready?
composer fix