Skip to content

Fix zero value on range field #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastianallgeier merged 3 commits into from
May 4, 2020
Merged

Fix zero value on range field #2549

bastianallgeier merged 3 commits into from
May 4, 2020

Conversation

@afbora
Copy link
Member

@afbora afbora commented Mar 31, 2020 •
edited
Loading

Describe the PR

Fixed zero value with checking null control.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Fixed code style issues with CS fixer and composer fix
  • Added in-code documentation (if needed)

@afbora afbora self-assigned this Mar 31, 2020
This was referenced Mar 31, 2020
Merged
Merged
afbora added a commit that referenced this pull request Mar 31, 2020
@afbora
Improve pointing on empty value
6afe7a3 
#2549
lukasbestle pushed a commit that referenced this pull request Apr 4, 2020
@afbora @lukasbestle
Improve pointing on empty value
1d2ee42 
#2549
@lukasbestle lukasbestle force-pushed the fix-zero-value-range-field branch from 6afe7a3 to 1d2ee42 Compare April 4, 2020 14:20
@lukasbestle lukasbestle force-pushed the fix-zero-value-range-field branch from 1d2ee42 to 65b013e Compare April 4, 2020 14:21
@lukasbestle
Copy link
Member

lukasbestle commented Apr 4, 2020

@afbora I have fixed the unit test failure in the excerpt method directly on the develop branch and rebased this PR against the develop branch. It's better to keep every PR for one change/fix/feature only.

Please also use the fix/<issue>-name naming scheme for branches in the future instead of fix-name. It's not an issue for your existing PRs, but in the future this will help keeping our branch list clean.

@bastianallgeier bastianallgeier merged commit 5091036 into develop May 4, 2020
@bastianallgeier bastianallgeier deleted the fix-zero-value-range-field branch May 4, 2020 13:20
@afbora afbora added this to the 3.4.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@distantnative distantnative Awaiting requested review from distantnative

Assignees

@afbora afbora

Labels

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@afbora @lukasbestle @bastianallgeier