Damn, something broke...

@lukasbestle We actually have a small breaking change:
We can't add the new parameter as last one, as ->apply() always modifies/returns the last parameter.

Hm, that's unfortunate.

Maybe we should instead use the opportunity to replace all those hook arguments ($path, $method, $used and maybe even $route) with one RouteRequest object that carries all the information. That would probably be cleaner in the long run.

Of course this would be something for 3.4 then, but I'd say it would be better to have this breaking-change than to change the param order. The issue with the new param order is that it won't make existing code fail, it would only make it not work properly. If we instead cut down on the arguments, existing hooks will fail hard because they aren't passed enough arguments.

I changed the milestone

Requires #2541 for a proper implementation.

What's the state of this @distantnative & @lukasbestle? Is it compatible with #2541 ?

@bastianallgeier Now that you have merged the other PR, we can update this to work with the changed structure. I will finalize this PR soon.

I have now rebased this PR against develop to pull in the changes from #2541.

Because the new $app->apply() implementation now allows modifying an argument that is not the last one, I was able to move the new $used argument to last position for maximum backwards-compatibility.

But because hooks can now request just the arguments they need, the order doesn't matter in the end – it's just relevant for the underlying Router::$afterEach callback where the argument order does matter.

❤️

I started calling it $used myself, but maybe $final would be the better name.

@distantnative I agree. Feel free to change it. :)

@distantnative @lukasbestle $final sounds more intuitive to me as well.

@distantnative Could you please make the change? As I'm not the author of the PR, I don't have full access to the Travis build etc.

Will do

Done, ready.