-
-
Notifications
You must be signed in to change notification settings - Fork 186
Fix range field default value #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix range field default value #2066
Conversation
|
It looks good to me but I haven't been able to test it myself. |
|
I made a few small changes. The computed position value should be used in all places. Then it works as expected. |
|
Sorry for posting here but it seems closely related: It seems to me that this is a JS zero/null confusion caused by the code changes above. The original line 80 in RangeInput.vue explicitly compared with null, where the change now only uses I tried to test/fix it in my kirby installation but apparently the vue sources are not directly used but need some build step I have no idea how to perform. |
Describe the PR
@distantnative Need your review for this simple PR :))
Fixed Preview Field
Related issues
Todos
composer fix