openapi3: include local reference parts in refPath saved #978
Conversation
* The local part was not included when visiting components during recursion * Also handles the case when base path is null when loading files data in memory * Copy uri.URL elements to avoid manipulation from outside source
fenollp
changed the title
fenollp
left a comment
fenollp
left a comment
There was a problem hiding this comment.
LGTM. Any regression tests to include before we merge this?
I thought you might ask :P, I will look at adding at least one direct test of the refPath of component references. There are a good amount of indirect tests (like internalise reference naming) but not for this particular case. I want to do that later today, we'll see if that happens |
|
Struggling to come up with test case, ideally we'd like to walk through the referenced components in a document. That almost involves re-implementing the resolving in loader.go. I think there are sufficent test cases for most the logic, up to you if you merge prior to additional tests for this specific case. I'll have to come back to this another time |
2 participants
A bug fix for code added in #955 for a seldom run code path with recursive refs