openapi3filter: support deepObject with nested objects and array parameters #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicc097
force-pushed
the
deepobject-array-query-parameters
branch
from
d5bafb2 to
f7bc1ca
Compare
fenollp
requested changes
Feb 19, 2024
Collaborator
fenollp
left a comment
fenollp
left a comment
There was a problem hiding this comment.
Just that one comment, otherwise LGTM
fenollp
changed the title
danicc097
force-pushed
the
deepobject-array-query-parameters
branch
from
eb03a92 to
65ad219
Compare
fenollp
approved these changes
Feb 19, 2024
Collaborator
|
LGTM. If you still intend to add more tests, we can wait till you add them to this PR that's fine by me. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danicc097
force-pushed
the
deepobject-array-query-parameters
branch
from
8fc092c to
a978d34
Compare
Contributor
Author
|
I think this should do it for now. Let me know if you feel something is missing |
fenollp
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will try to add missing nested object array items support soon, if you see no issues with the approach taken
Fixes #294