Repository navigation
openapi3filter: skip schema checks for empty allowEmptyValue strings - #1228
Merged
fenollp merged 1 commit intoJul 19, 2026
Merged
Conversation
getkin#1096 made parsePrimitive return empty string for string types instead of nil. Format and other schema checks then still ran when allowEmptyValue was set. Skip those checks for empty strings when allowEmptyValue is true. Fixes getkin#1134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134.
#1096 stopped turning empty string params into nil, so format validation still fires on values like
dateOfBirth=even when allowEmptyValue is true. Skip schema checks in that case.Regression in openapi3filter/issue1134_test.go.