Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicates being created with the same URL #765

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Prevent duplicates being created with the same URL #765

merged 13 commits into from
Oct 8, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

@paulrobertlloyd paulrobertlloyd commented Oct 6, 2024 •
edited
Loading

Fixes #731.

  • Use md5 hash of published date to create slug token; this means the slug remains a constant value, and therefore so does the URL (including those that include a slug token)
  • Use replaceOne with upsert when creating new posts
  • Use replaceOne with upsert when creating new files
  • Update Bitbucket store to not attempt to create a new file if already exists
  • Update file system store to not create a new file if already exists
  • Update FTP store to not create a new file if already exists
  • Update GitHub store to not create a new file if already exists
  • Update Gitea store to not create a new file if already exists
  • Update GitLab store to not create a new file if already exists
  • Update S3 store to not create a new file if already exists

@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Oct 6, 2024
@paulrobertlloyd paulrobertlloyd changed the title Prevent duplicate posts being created with the same URL Prevent duplicates being created with the same URL Oct 6, 2024
@paulrobertlloyd paulrobertlloyd force-pushed the fix/731-prevent-duplicates branch 5 times, most recently from 0f45ee6 to 3e03b26 Compare October 8, 2024 19:20
@paulrobertlloyd paulrobertlloyd marked this pull request as ready for review October 8, 2024 19:36
@paulrobertlloyd
feat(util): md5
39bab37
@paulrobertlloyd
feat(endpoint-micropub): use md5 hash of published date as final opti…
dbcd864 
…on for a slug

this means the value stays the same, and doesn’t change each time a post is re-created
@paulrobertlloyd
ci: use slug for photo post paths
cefbadd
@paulrobertlloyd
feat(endpoint-micropub): replace existing if creating a post with the…
10b08c4 
… same url
@paulrobertlloyd
feat(endpoint-media): replace existing if uploading media with the sa…
ac1a4d9 
…me url
@paulrobertlloyd
feat(store-bitbucket): check if file exists before creating
580cf90
@paulrobertlloyd
feat(store-file-system): check if file exists before creating
68db0ab
@paulrobertlloyd
fix(store-ftp): check if file exists before creating
5c7b88a
@paulrobertlloyd
feat(store-github): check if file exists before creating
ac066e3
@paulrobertlloyd
fix(store-gitea): check if file exists before creating
9c43ce8
@paulrobertlloyd
fix(store-gitlab): update integration
34958a5
@paulrobertlloyd
fix(store-gitlab): check if file exists before creating
1ff3192
@paulrobertlloyd
fix(store-s3): check if file exists before creating
8806da1
@paulrobertlloyd paulrobertlloyd force-pushed the fix/731-prevent-duplicates branch from 3e03b26 to 8806da1 Compare October 8, 2024 19:48
@paulrobertlloyd paulrobertlloyd merged commit e1468c4 into main Oct 8, 2024
1 check failed
@paulrobertlloyd paulrobertlloyd deleted the fix/731-prevent-duplicates branch October 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Duplication prevention
1 participant
@paulrobertlloyd