Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty properties are not ignored when performing post type discovery #756

Closed
paulrobertlloyd opened this issue Aug 20, 2024 · 0 comments · Fixed by #757
Closed

Empty properties are not ignored when performing post type discovery #756

paulrobertlloyd opened this issue Aug 20, 2024 · 0 comments · Fixed by #757
Assignees
@paulrobertlloyd
Labels
bug Something isn't working plugin-endpoint Endpoint plug-in
Milestone
v1.0

Comments

@paulrobertlloyd
Copy link
Collaborator

paulrobertlloyd commented Aug 20, 2024 •
edited
Loading

Description of the bug

The following incoming properties:

{
  "type": "entry",
  "name": "",
  "content": "Note content",
}

are perceived to be that of an article post type, even though there is in effect no title.

Steps to reproduce

No response

Expected behaviour

Empty properties should be ignored.

Environment

  • Indiekit version 1.0.0-beta.17

Additional context

Added a unit test for this use case, and am seeing the issue as reported to me by @gerwitz.
@paulrobertlloyd paulrobertlloyd added the bug Something isn't working label Aug 20, 2024
@paulrobertlloyd paulrobertlloyd self-assigned this Aug 20, 2024
@paulrobertlloyd paulrobertlloyd added the plugin-endpoint Endpoint plug-in label Aug 20, 2024
@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Aug 20, 2024
paulrobertlloyd added a commit that referenced this issue Aug 20, 2024
@paulrobertlloyd
fix(endpoint-micropub): ignore empty name property in PTD. fixes #756
80c5260
@paulrobertlloyd paulrobertlloyd mentioned this issue Aug 20, 2024
Merged
paulrobertlloyd added a commit that referenced this issue Aug 20, 2024
@paulrobertlloyd
fix(endpoint-micropub): ignore empty name property in PTD. fixes #756
02baa2b
paulrobertlloyd added a commit that referenced this issue Aug 22, 2024
@paulrobertlloyd
fix(endpoint-micropub): ignore empty name property in PTD. fixes #756
beafcea
paulrobertlloyd added a commit that referenced this issue Aug 22, 2024
@paulrobertlloyd
fix(endpoint-micropub): ignore empty name property in PTD. fixes #756
6bbb284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulrobertlloyd paulrobertlloyd

Labels
bug Something isn't working plugin-endpoint Endpoint plug-in
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Ignore empty name property in post type discovery getindiekit/indiekit
1 participant
@paulrobertlloyd