fix(store-ftp): check if file exists before creating

paulrobertlloyd · paulrobertlloyd · commit e50e32c8a643 · 2024-10-08T20:54:46.000+01:00
diff --git a/packages/store-ftp/index.js b/packages/store-ftp/index.js
@@ -118,6 +118,12 @@ export default class FtpStore {
       const readableStream = this.#createReadableStream(content);
       const absolutePath = this.#absolutePath(filePath);
 
+      // Return if file already exists
+      const fileExists = await client.exists(absolutePath);
+      if (fileExists) {
+        return;
+      }
+
       // Create directory if doesn’t exist
       const directory = path.dirname(absolutePath);
       const directoryType = await client.exists(directory);
diff --git a/packages/store-ftp/test/index.js b/packages/store-ftp/test/index.js
@@ -75,6 +75,12 @@ describe("store-ftp", () => {
     );
   });
 
+  it("Doesn’t create file if already exists", async () => {
+    await ftp.createFile("foo.md", "foobar");
+
+    assert.equal(await ftp.createFile("foo.md", "foobar"), undefined);
+  });
+
   it("Throws error creating file", async () => {
     await assert.rejects(ftp.createFile(undefined, ""), {
       message: `FTP store: The "path" argument must be of type string. Received undefined`,
