fix(frontend): svg icons with titles should be focusable

paulrobertlloyd · paulrobertlloyd · commit cc5fde9f4187 · 2024-04-14T13:50:01.000+01:00
diff --git a/packages/frontend/lib/globals/icon.js b/packages/frontend/lib/globals/icon.js
@@ -62,7 +62,7 @@ export const icon = (name, title) => {
   }
 
   const svg = title
-    ? `<svg class="icon" xmlns="http://www.w3.org/2000/svg" height="1em" width="1em" viewBox="0 0 48 48" focusable="false" aria-labelledby="${name}-title" role="img">
+    ? `<svg class="icon" xmlns="http://www.w3.org/2000/svg" height="1em" width="1em" viewBox="0 0 48 48" aria-labelledby="${name}-title" role="img">
     <title id="${name}-title">${title}</title>
     <path fill="currentColor" d="${paths[name]}"/>
   </svg>`

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ export const icon = (name, title) => {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`const svg = title`
`65`		- ? `<svg class="icon" xmlns="http://www.w3.org/2000/svg" height="1em" width="1em" viewBox="0 0 48 48" focusable="false" aria-labelledby="${name}-title" role="img">
	`65`	+ ? `<svg class="icon" xmlns="http://www.w3.org/2000/svg" height="1em" width="1em" viewBox="0 0 48 48" aria-labelledby="${name}-title" role="img">
`66`	`66`	`<title id="${name}-title">${title}</title>`
`67`	`67`	`<path fill="currentColor" d="${paths[name]}"/>`
`68`	`68`	</svg>`