fix(endpoint-micropub): ignore empty name property in PTD. fixes #756

paulrobertlloyd · paulrobertlloyd · commit 6bbb28414b53 · 2024-08-22T16:33:37.000+01:00
diff --git a/packages/endpoint-micropub/lib/post-type-discovery.js b/packages/endpoint-micropub/lib/post-type-discovery.js
@@ -59,7 +59,7 @@ export const getPostType = (postTypes, properties) => {
   // If post has `name` and content, it’s an article
   // This is a deviation from the Post Type Algorithm, which identifies a post
   // as a note if the content is prefixed with the `name` value.
-  if (propertiesMap.has("name") && content) {
+  if (properties.name && content) {
     return "article";
   }
 
diff --git a/packages/endpoint-micropub/test/unit/post-type-discovery.js b/packages/endpoint-micropub/test/unit/post-type-discovery.js
@@ -17,6 +17,16 @@ describe("endpoint-media/lib/post-type-discovery", () => {
     assert.equal(result, "note");
   });
 
+  it("Discovers note post type (with an empty title)", () => {
+    const result = getPostType(postTypes, {
+      type: "entry",
+      name: "",
+      content: "Note content",
+    });
+
+    assert.equal(result, "note");
+  });
+
   it("Discovers article post type", () => {
     const result = getPostType(postTypes, {
       type: "entry",
@@ -88,6 +98,20 @@ describe("endpoint-media/lib/post-type-discovery", () => {
     assert.equal(result, "article");
   });
 
+  it("Discovers article post type (content begins with name)", () => {
+    // Indiekit deviates from the Post Type Algorithm, which identifies a post
+    // as a note if the content is prefixed with the `name` value.
+    const result = getPostType(postTypes, {
+      type: "entry",
+      name: "Article about something",
+      content: {
+        text: "Article about something fishy.",
+      },
+    });
+
+    assert.equal(result, "article");
+  });
+
   it("Discovers photo post type", () => {
     const result = getPostType(postTypes, {
       type: "entry",

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export const getPostType = (postTypes, properties) => {`
`59`	`59`	// If post has `name` and content, it’s an article
`60`	`60`	`// This is a deviation from the Post Type Algorithm, which identifies a post`
`61`	`61`	// as a note if the content is prefixed with the `name` value.
`62`		`- if (propertiesMap.has("name") && content) {`
	`62`	`+ if (properties.name && content) {`
`63`	`63`	`return "article";`
`64`	`64`	`}`
`65`	`65`