chore(wire): increase DNS_SEED_REQUEST_INTERVAL#870
Merged
Davidson-Souza merged 1 commit intoMar 9, 2026
Conversation
Member
Author
|
Oh, how fun: |
Member
|
The Rust developers had to ask Chronos for permission, hours is something serious |
Davidson-Souza
force-pushed
the
increase-dns-seeds-time
branch
from
60255fe to
350ee97
Compare
Member
Author
Yeah, they probably needed to ask some representatives as well, since it's [h]ours, not theirs 🥁 🥁 🥁 |
JoseSK999
reviewed
Mar 6, 2026
Comment on lines
467
to
477
Member
There was a problem hiding this comment.
Unrelated but nicer style here
let default_port = Self::get_port(network);
let dns_seeds = floresta_chain::get_chain_dns_seeds(network);
let mut addresses = Vec::new();
for seed in &dns_seeds {
if let Ok(got) = AddressMan::get_seeds_from_dns(seed, default_port, proxy_addr) {
addresses.extend(got);
}
}
Member
|
Nit: fix the typo in PR description |
Davidson-Souza
changed the title
Member
|
CACK |
In getfloresta#793 we reduced the `DNS_SEED_REQUEST_INTERVAL` to two minutes. This tells how long do we wait before re-doing a request do the DNS seeds. The goal was to make sure we had enough peers to keep going. However, it doesn't seem like it worked as intended since DNS servers are currently bad at giving utreexo peers (and on signet they are also bad at giving CBS peers). This forces our node to retry DNS requests every two minutes. But since most users don't have their own recursive resolver (I don't), the previous result is almost always cached, so you get basically the same answer several times. This pollutes stdout for no good reason. Since getfloresta#781 we now are super aggressive about asking for addresses and checking whether they are alive and learning about their capabilities and getfloresta#865 will make it even better, since we can try several feeler connections at the same time. So I think DNS seeds should be only used to get us some starting peers, and then we build our local network view from the P2P net ourselves.
Davidson-Souza
force-pushed
the
increase-dns-seeds-time
branch
from
350ee97 to
0ceeb59
Compare
Member
Author
|
Pushed 0ceeb59 addressing a small nit by @JoseSK999 |
JoseSK999
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
In #793 we reduced the
DNS_SEED_REQUEST_INTERVALto two minutes.This tells how long do we wait before re-doing a request do the DNS
seeds. The goal was to make sure we had enough peers to keep going.
However, it doesn't seem like it worked as intended since DNS servers
are currently bad at giving utreexo peers (and on signet they are also
bad at giving CBS peers). This forces our node to retry DNS requests
every two minutes. But since most users don't have their own recursive
resolver (I don't), the previous result is almost always cached, so you
get basically the same answer several times.
This pollutes stdout for no good reason. Since #781 we now are super
aggressive about asking for addresses and checking whether they are
alive and learning about their capabilities and #865 will make it
even better, since we can try several feeler connections at the same
time. So I think DNS seeds should be only used to get us some starting
peers, and then we build our local network view from the P2P net
ourselves.