Crash may occur on opening/saveing files

Hiroshi Yoshikawa · ooxi · commit 242dda66b81e · 2021-08-29T17:39:44.000+02:00
This is caused by passing NULL to strchr() function. Behavior of strchr(NULL, c) is implementation-dependent. Indeed, MinGW-w64 gcc crashes if strchr(NULL, c) is executed. https://sourceforge.net/p/gerbv/patches/83/
diff --git a/src/project.c b/src/project.c
@@ -564,6 +564,8 @@ get_value_string(scheme *sc, pointer value)
 static char *
 convert_path_separators(char* path, int conv_flag)
 {
+    if (path == NULL) return NULL;
+
 #if defined (__MINGW32__)        
     char     *hit_in_path;
 

Original file line number	Diff line number	Diff line change
`@@ -564,6 +564,8 @@ get_value_string(scheme *sc, pointer value)`
`564`	`564`	`static char *`
`565`	`565`	`convert_path_separators(char* path, int conv_flag)`
`566`	`566`	`{`
	`567`	`+ if (path == NULL) return NULL;`
	`568`	`+`
`567`	`569`	`#if defined (__MINGW32__)`
`568`	`570`	`char *hit_in_path;`
`569`	`571`