Repository navigation
Validate the subspace constraint for spherical tangent vectors - #267
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a sphere restricted by
intersectionorcomplement, a tangent vector must belong to the allowed subspace as well as being orthogonal to the base point. The tangent checker currently only tests orthogonality, so it accepts vectors normal to the allowed subspace.Check that the vector is unchanged by the existing subspace projection. Preserve the existing orthogonality failure and expose the violated subspace constraint through the assertion message.
Validation on current master with Python 3.12 / PyTorch 2.8.0 CPU and full native package imports:
test_manifold_basic.pycases plus the focused file: 1,897 passed, 310 existing parameterized skips.git diff --checkpass.The branch preserves both new master commits. The complete repository suite, CUDA and the Sphinx documentation gate were not run for this change.