Repository navigation
Propagate product metric parallel transport to factors - #2131
Conversation
|
At Could you advise how to fulfill the required full-suite validation under these limits? Separately, DeepSource fails at 58.9% documentation coverage and reports nine existing definitions that are AST-identical to pristine source, while warning that its branch baseline may be inaccurate. Could you advise how to investigate that baseline/coverage gate? This remains an unready draft. |
f74c2cc to
e4040ed
Compare
luisfpereira
left a comment
There was a problem hiding this comment.
Thank you @Afloat16!
I've made the tests lighter (by deleting some of the additions) because the product Hypersphere(dim=3, equip=False), Hyperboloid(dim=3, equip=False) allows for parallel transport (and the current tests automatically check its properties).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
+ Coverage 90.38% 90.50% +0.12%
==========================================
Files 171 171
Lines 15852 15978 +126
==========================================
+ Hits 14327 14459 +132
+ Misses 1525 1519 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #2130, reported by @luisfpereira.
ProductRiemannianMetricinherits an unimplementedparallel_transport, soPolyHyperbolicCholeskyMetricworks for 2×2 correlation matrices but fails for 3×3 and larger ones. The product connection splits across factors; delegate transport to those metrics using the existing argument projection and output packing. Factors without transport continue to raise their own unsupported-operation error.Tests cover direction/end-point paths, flat/stacked representations, batching, factor results, tangency and norm preservation. A 3×3 correlation regression checks both paths and reverse transport.
Verification and unmet prerequisites
This draft does not meet the contributing guide's all-tests-pass prerequisite.
Exact head
22959f5045dc87b13ef4e57267d454e58598912e, Python 3.12.14 with supported dependency bounds, CPU:9941df0a3(NumPy). Four affected native modules passed 2641 tests per backend, with 49 skips.pytest --cov=geomstats tests/on NumPy, including slow/redundant/script nodes: 17284 passed, 26 failed, 556 skipped, 61 xfailed, 212 xpassed; every one of the 18139 collected nodes is accounted for. Six failures are LieCholeskyMetric assertions. Twenty are notebook kernel startup blockers: ZeroMQ reportsOperation not permitted, followed byKernel died before replying to kernel_info; their notebook cells were not executed. A supported escalated kernel smoke has the same failure.wheredtype (Fix where for autograd #2118/Fix Autograd where output type #2129), and TorchLBFGS failures on unchanged paths. Baseline evidence does not waive the full-test prerequisite.git diff --checkand Sphinx-Wrendering of the new method pass.Full-project documentation, GPU and the CI Python-version matrix were not run locally.
Checklist
Current CI gate
DeepSource reports failure with documentation coverage at 58.9%, below the repository threshold, and warns that its branch baseline may be inaccurate. Its nine “introduced” findings all refer to existing definitions that are AST-identical to pristine
9941df0a3; none points to the new transport or tests. The run needs maintainer baseline/gate review. GitHub Actions are also awaiting approval.