Repository navigation
Commit eec2dff
authored
ci: Check datafusion-spark feature combinations to catch publish errors (apache#24475)
## Which issue does this PR close?
- Closes apache#24474
## Rationale for this change
Publishing `datafusion-spark` 55.0.0 failed with
```
error[E0433]: cannot find module or crate `datafusion` in this scope
--> src/function/string/quote.rs:20:5
```
because the library referenced the optional `datafusion` dependency
(only enabled by the `core` feature) from code that is not gated on that
feature.
CI did not catch this workspace-wide builds always compile
`datafusion-spark` with the optional `datafusion` dependency present due
to feature unification.
The underlying import error was already fixed on `main` in apache#24351, so
this PR adds the missing CI coverage to prevent the problem from
reoccurring.
## What changes are included in this PR?
Add a `cargo check datafusion-spark features` CI job, following the
pattern of the existing per-crate feature check jobs (e.g.
`datafusion-functions`), that checks the crate standalone.
Also add the new job to the required status checks in `.asf.yaml`, like
the other per-crate feature check jobs.
## Are these changes tested?
Yes, by CI itself (the new job runs on this PR).
## Are there any user-facing changes?
No, CI only.1 parent 309dad8 commit eec2dff
2 files changed
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
290 | 317 | | |
291 | 318 | | |
292 | 319 | | |
| |||
0 commit comments