Repository navigation
Commit a95754f
committed
fix: keep required sorts above custom execution plans
Keep sorts above operators without explicit sort-pushdown handling.
Preserve known built-in input mappings and make custom-node support
opt-in through the existing try_pushdown_sort API.
Cover correct query results and sort placement for a value-transforming
custom projection, built-in input mappings, and explicit custom support.
Closes apache#26656.1 parent e8940ac commit a95754f
8 files changed
Lines changed: 288 additions & 202 deletions
File tree
- datafusion
- core/tests/physical_optimizer
- physical-optimizer/src/ensure_requirements/enforce_sorting
- physical-plan/src
- sqllogictest
- src
- test_context
- test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2735 | 2735 | | |
2736 | 2736 | | |
2737 | 2737 | | |
2738 | | - | |
| 2738 | + | |
2739 | 2739 | | |
2740 | | - | |
| 2740 | + | |
2741 | 2741 | | |
2742 | 2742 | | |
2743 | 2743 | | |
| |||
2749 | 2749 | | |
2750 | 2750 | | |
2751 | 2751 | | |
2752 | | - | |
2753 | | - | |
2754 | | - | |
2755 | | - | |
2756 | | - | |
2757 | | - | |
2758 | | - | |
2759 | | - | |
2760 | 2752 | | |
2761 | 2753 | | |
2762 | 2754 | | |
2763 | | - | |
| 2755 | + | |
2764 | 2756 | | |
2765 | 2757 | | |
2766 | 2758 | | |
2767 | 2759 | | |
2768 | | - | |
2769 | | - | |
2770 | | - | |
2771 | | - | |
2772 | | - | |
2773 | 2760 | | |
2774 | | - | |
2775 | 2761 | | |
2776 | 2762 | | |
2777 | 2763 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | | - | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| |||
1098 | 1100 | | |
1099 | 1101 | | |
1100 | 1102 | | |
1101 | | - | |
1102 | | - | |
1103 | | - | |
| 1103 | + | |
1104 | 1104 | | |
1105 | 1105 | | |
1106 | 1106 | | |
1107 | 1107 | | |
1108 | 1108 | | |
1109 | 1109 | | |
1110 | 1110 | | |
1111 | | - | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
1112 | 1116 | | |
1113 | | - | |
1114 | | - | |
1115 | | - | |
1116 | | - | |
1117 | | - | |
1118 | | - | |
1119 | | - | |
1120 | | - | |
1121 | | - | |
1122 | | - | |
1123 | | - | |
1124 | | - | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
1125 | 1144 | | |
1126 | 1145 | | |
1127 | 1146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1061 | 1061 | | |
1062 | 1062 | | |
1063 | 1063 | | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
1064 | 1068 | | |
1065 | 1069 | | |
1066 | 1070 | | |
| |||
0 commit comments