Repository navigation
Commit 2bf86aa
committed
fix: keep required sorts above custom execution plans
Keep sorts above operators without explicit sort-pushdown handling.
Preserve known built-in input mappings and make custom-node support
opt-in through the existing try_pushdown_sort API.
Cover correct query results and sort placement for a value-transforming
custom projection, built-in input mappings, and explicit custom support.
Closes apache#26656.1 parent 350ca76 commit 2bf86aa
8 files changed
Lines changed: 288 additions & 202 deletions
File tree
- datafusion
- core/tests/physical_optimizer
- physical-optimizer/src/ensure_requirements/enforce_sorting
- physical-plan/src
- sqllogictest
- src
- test_context
- test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2604 | 2604 | | |
2605 | 2605 | | |
2606 | 2606 | | |
2607 | | - | |
| 2607 | + | |
2608 | 2608 | | |
2609 | | - | |
| 2609 | + | |
2610 | 2610 | | |
2611 | 2611 | | |
2612 | 2612 | | |
| |||
2618 | 2618 | | |
2619 | 2619 | | |
2620 | 2620 | | |
2621 | | - | |
2622 | | - | |
2623 | | - | |
2624 | | - | |
2625 | | - | |
2626 | | - | |
2627 | | - | |
2628 | | - | |
2629 | 2621 | | |
2630 | 2622 | | |
2631 | 2623 | | |
2632 | | - | |
| 2624 | + | |
2633 | 2625 | | |
2634 | 2626 | | |
2635 | 2627 | | |
2636 | 2628 | | |
2637 | | - | |
2638 | | - | |
2639 | | - | |
2640 | | - | |
2641 | | - | |
2642 | 2629 | | |
2643 | | - | |
2644 | 2630 | | |
2645 | 2631 | | |
2646 | 2632 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | | - | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
1111 | 1113 | | |
1112 | 1114 | | |
1113 | 1115 | | |
1114 | | - | |
1115 | | - | |
1116 | | - | |
| 1116 | + | |
1117 | 1117 | | |
1118 | 1118 | | |
1119 | 1119 | | |
1120 | 1120 | | |
1121 | 1121 | | |
1122 | 1122 | | |
1123 | 1123 | | |
1124 | | - | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
1125 | 1129 | | |
1126 | | - | |
1127 | | - | |
1128 | | - | |
1129 | | - | |
1130 | | - | |
1131 | | - | |
1132 | | - | |
1133 | | - | |
1134 | | - | |
1135 | | - | |
1136 | | - | |
1137 | | - | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
1138 | 1157 | | |
1139 | 1158 | | |
1140 | 1159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1074 | 1074 | | |
1075 | 1075 | | |
1076 | 1076 | | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
1077 | 1081 | | |
1078 | 1082 | | |
1079 | 1083 | | |
| |||
0 commit comments