Skip to content

Add testcases for various housenumber types#28

Merged
yohanboniface merged 3 commits intogeocoders:masterfrom
hbruch:add_housenumber_tests
Jan 11, 2018
Merged

Add testcases for various housenumber types#28
yohanboniface merged 3 commits intogeocoders:masterfrom
hbruch:add_housenumber_tests

Conversation

@hbruch
Copy link
Copy Markdown
Contributor

@hbruch hbruch commented Jan 3, 2018

Add some testcases for housenumbers with various suffixes, case variations, hyphenation etc.

nlehuby
nlehuby reviewed Jan 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@nlehuby nlehuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If you don't use the lon, lat limit, expected_name and expected_postcode columns, you don't need to add them in your test file.

@hbruch hbruch mentioned this pull request Jan 5, 2018
Closed
@nlehuby
Copy link
Copy Markdown
Contributor

nlehuby commented Jan 10, 2018

@yohanboniface do you want to review this PR? Otherwise, I'll merge it.

@hbruch
Copy link
Copy Markdown
Contributor Author

hbruch commented Jan 10, 2018

I just noticed I need to provide lang=de, so geocoder instances defaulting to english would return 'Hannover' instead of 'Hannover'.

@hbruch
Copy link
Copy Markdown
Contributor Author

hbruch commented Jan 10, 2018

Another question: are there any conventions for the names of subfolders, e.g. modelling the osm admin-level hierarchy? Probably I should then rename the folder to niedersachsen?

@hbruch
Add lang=de and further tests
44d571e 
Signed-off-by: Holger Bruch <[email protected]>
@hbruch hbruch mentioned this pull request Jan 10, 2018
Merged
@yohanboniface
Copy link
Copy Markdown
Member

yohanboniface commented Jan 11, 2018

Another question: are there any conventions for the names of subfolders, e.g. modelling the osm admin-level hierarchy? Probably I should then rename the folder to niedersachsen?

There is no convention at this level. The constraint is that every subfolder is automatically transformed as a tag (so it can be used as filters when running py.test) so for example it should not contain dashes (otherwise they are parsed as "minus" by pytest).
As you have certainly noticed, he usage is to have geographical subfolders, and inside them optional "typed" subfolders.
I think we need to be consistent for the "typed" subfolders (given they are used several times), but geographical subfolders are fine as soon as people interested in this area understand its name.

@yohanboniface yohanboniface merged commit 1333340 into geocoders:master Jan 11, 2018
antoine-de pushed a commit to antoine-de/geocoder-tester that referenced this pull request Sep 21, 2018
@amatissart
Merge pull request geocoders#28 from antoine-de/cleanup_repo
a33d9d5 
clean the repository by deleting useless files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlehuby nlehuby nlehuby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbruch @nlehuby @yohanboniface