Repository navigation
docs(releasekit): adopt release-please model - #4575
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the releasekit roadmap to reflect the adoption of a Release-Please style workflow. The changes are well-documented and clearly explain the new versioning strategies and cross-repository workflow.
I've found a couple of areas in the new documentation that could be improved for clarity and consistency with the provided code context: a minor typo and a more significant inconsistency regarding how dependency updates trigger version bumps. My detailed comments are below.
- D-11: transitive PATCH propagation (not 'no propagation') - Pipeline: rewritten as 3-command split (prepare/tag/publish) - Phase 5: renamed to 'Release-Please', added prepare.py + release.py - Mermaid: replaced commitbackmod with preparemod + releasemod - versioning.py: supports transitive propagation + synchronize mode - File tree: replaced commitback with prepare/release modules and tests
Roadmap Update: Release-Please Model & Independent Versioning
This PR refactors the
releasekitroadmap to adopt a Release-Please style workflow and introduces a robust Independent Versioning strategy for the monorepo.Key Changes
New Lifecycle Commands (replaces monolithic pipeline)
prepare: Scans commits, computes bumps (with transitive propagation), updatespyproject.toml/lockfiles, generates changelogs, and creates/updates a Release PR with an embedded manifest.tag: Triggered on Release PR merge. Parses the manifest, tags the merge commit, and creates a GitHub Release.publish: Triggered on Release creation. Builds with ephemeral pinning, uploads to PyPI, and dispatches to downstream repos.Versioning Strategy
synchronize = true) where all packages share the same version.Cross-Repository Support
repository_dispatchafter publish.releasekit prepare, which detects external updates viauv lock --upgrade-package.Contradictions Resolved
commitback.pyreferences (replaced withprepare.py+release.py).preparemod+releasemodnodes.versioning.pydescription updated to reflect transitive propagation +synchronizemode.Architecture
Dependency Tree Propagation
Release Lifecycle