Closed
Conversation
This mirrors the AWS source repo exactly.
silicon-jc
suggested changes
Aug 20, 2020
silicon-jc
left a comment
silicon-jc
left a comment
There was a problem hiding this comment.
This PR doesn't change the setup.py to remove the pinned botocore version - I'd suggest removing it so current botocore can be used with cfnresponse.
Owner
|
Sorry for the delay on this, ya, upstream switched to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the AWS source repo exactly. botocore no longer includes vendored requests, but urllib3 is available to all lambdas. This is a super useful package on PyPi. This update will allow it to be used for many more years.