Skip to content

Commit b6433ac

Browse files
fix(queries): route WITH-prefixed statements through the query path on MySQL/SQLite
MySQL and SQLite only allow WITH before read-only SELECT, yet both adapters classified statements by prefix without WITH, so `WITH ... SELECT` fell into the write branch: rusqlite's execute() rejects row-returning statements with ExecuteReturnedResults, making CTE reads on SQLite hard-error. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
1 parent 29fc28a commit b6433ac

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎src-tauri/src/database/mysql.rs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,8 @@ impl DatabaseAdapter for MySQLAdapter {
625625
let is_select = query_trimmed.starts_with("SELECT")
626626
|| query_trimmed.starts_with("SHOW")
627627
|| query_trimmed.starts_with("DESCRIBE")
628-
|| query_trimmed.starts_with("EXPLAIN");
628+
|| query_trimmed.starts_with("EXPLAIN")
629+
|| query_trimmed.starts_with("WITH");
629630

630631
let execution_time;
631632

‎src-tauri/src/database/sqlite.rs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,8 @@ impl SQLiteAdapter {
380380
let trimmed = query.trim().to_uppercase();
381381
let is_select = trimmed.starts_with("SELECT")
382382
|| trimmed.starts_with("PRAGMA")
383-
|| trimmed.starts_with("EXPLAIN");
383+
|| trimmed.starts_with("EXPLAIN")
384+
|| trimmed.starts_with("WITH");
384385

385386
if is_select {
386387
let mut stmt = conn_guard

0 commit comments

Comments
 (0)