Skip to content

Android - Stop alarm on notification dismiss - #336

Merged
gdelataillade merged 1 commit into
gdelataillade:mainfrom
ahamsel:fix/android-stop-alarm-on-notification-dismiss
Mar 5, 2025
Merged

gdelataillade merged 1 commit into
gdelataillade:mainfrom
ahamsel:fix/android-stop-alarm-on-notification-dismiss

Conversation

@ahamsel

@ahamsel ahamsel commented Feb 23, 2025 •

Copy link
Copy Markdown
Contributor

I noticed when notification is dismissed there isn't a way to stop the alarm unless through a patch in the app. This could be a big issue, so why not stop it when swiped away/dismissed the same way as the stop button

@ahamsel ahamsel changed the title Stop alarm on notification dismiss Android - Stop alarm on notification dismiss Feb 23, 2025
@gdelataillade

Copy link
Copy Markdown
Owner

Thanks I'll review this tomorrow !

@gdelataillade gdelataillade left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdelataillade
gdelataillade merged commit 8967ddf into gdelataillade:main Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants