Fix data access and redirects #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-1991
added
type:bug
pdurbin
approved these changes
Apr 18, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Tests are passing. Looks like a straightforward change. I didn't test it but I'm approving this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes the
get_datafileendpoint and allows redirects upon requests, which is happening in the case of data access. Before this PR, theget_datafilemethod used the persistent ID access URL ifpid=Falseand vice versa. This has been fixed by simply switching theifstatements. In addition, tests have been added to pyDataverse to check if data access is working.TLDR
get_datafilemethod ofDataAccessApidue to wrong conditionsget_datafile(pid and id case)