-
Notifications
You must be signed in to change notification settings - Fork 47
Add CI/CD pipeline and re-establish existing tests #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is within a nested directory and thus not in the root's namespace
This might actually be harder to pull off than it sounds like. DV 5.x requires Payara 5, so different base image. We could build that of course, even cache some versions images. But to actually make this work, it might need doing some backports, because we evolved the images quite a bit when going from 5.x to recent develop, soon to be 6.1. |
|
@poikilotherm, it's good to note that the tests on pyDataverse were only done on How do you think we should proceed? Stick with |
|
Kudos, SonarCloud Quality Gate passed!
|
pdurbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig into the details but I'm so happy to see some CI working again! Ship it! 🚀
I tested it before on local running docker images and on our two instances we ran at AUSSDA, so something very recent, and some version half a year old or so. But never something really old, like more than 1.5y or one major version back. |








Describe your environment
Describe the PR
ToDos
3.7to3.11)test-actiontomainonce Added action tests dataverse-action#8Testing
Others
Tests run exclusively for Python version 3.10 at the moment but will expand to others in the PR progress. Is '>3.7' reasonable?