Skip to content

Conversation

@JR-1991
Copy link
Member

@JR-1991 JR-1991 commented Dec 2, 2023

Describe your environment

  • pyDataverse: 0.3.1
  • Python: 3.10
  • Dataverse: 6.0

Describe the PR

  • What kind of change does this PR introduce?
    • CI/CD pipeline to test pyDataverse using the dataverse-action
    • Minor changes to fetching Dataverse action outputs for testing
  • Why is this change required? What problem does it solve?
    • Re-establish the existing testing framework

ToDos

Testing

  • Have you used tox and/or pytest for testing the changes?
  • Did the local testing ran successfully?
  • Did the Continous Integration testing (GitHub Action) run successfully?

Others

  • The tests have been executed successfully (example run).
  • @pdurbin @poikilotherm - Currently, the action only tests against version 6.0. However, this pipeline should check multiple versions. @skasberger proposed that we test from version 5.x onwards. Therefore, we need to extend the Dataverse action.
  • Tests run exclusively for Python version 3.10 at the moment but will expand to others in the PR progress. Is '>3.7' reasonable?

@JR-1991 JR-1991 added type:feature New feature pkg:testing test related activities prio:high status:for review Waiting to be reviewd labels Dec 2, 2023
@JR-1991 JR-1991 self-assigned this Dec 2, 2023
@JR-1991 JR-1991 requested a review from pdurbin December 2, 2023 17:19
@poikilotherm
Copy link
Member

  • @pdurbin @poikilotherm - Currently, the action only tests against version 6.0. However, this pipeline should check multiple versions. @skasberger proposed that we test from version 5.x onwards. Therefore, we need to extend the Dataverse action.

This might actually be harder to pull off than it sounds like.

DV 5.x requires Payara 5, so different base image. We could build that of course, even cache some versions images.

But to actually make this work, it might need doing some backports, because we evolved the images quite a bit when going from 5.x to recent develop, soon to be 6.1.

@JR-1991
Copy link
Member Author

JR-1991 commented Dec 2, 2023

@poikilotherm, it's good to note that the tests on pyDataverse were only done on demo.dataverse.org up to this point. Therefore, no functionality will be lost. Also, the recent changes from version 5.x to 6.x may not affect pyDataverse testing too much since most of the endpoints pyDataverse has implemented remain the same (to my knowledge). However, it is still worth considering tests across versions in the future.

How do you think we should proceed? Stick with 6.x exclusively or work on the backports? I'd remove the ToDo here if we stick with the current case.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JR-1991 JR-1991 marked this pull request as ready for review December 6, 2023 08:46
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig into the details but I'm so happy to see some CI working again! Ship it! 🚀

@JR-1991 JR-1991 merged commit 7614def into master Dec 6, 2023
@skasberger
Copy link
Member

@poikilotherm, it's good to note that the tests on pyDataverse were only done on demo.dataverse.org up to this point. Therefore, no functionality will be lost. Also, the recent changes from version 5.x to 6.x may not affect pyDataverse testing too much since most of the endpoints pyDataverse has implemented remain the same (to my knowledge). However, it is still worth considering tests across versions in the future.

How do you think we should proceed? Stick with 6.x exclusively or work on the backports? I'd remove the ToDo here if we stick with the current case.

I tested it before on local running docker images and on our two instances we ran at AUSSDA, so something very recent, and some version half a year old or so. But never something really old, like more than 1.5y or one major version back.

@pdurbin pdurbin added this to the 0.3.2 milestone Mar 4, 2024
@JR-1991 JR-1991 deleted the dataverse-action-tests branch August 14, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:testing test related activities prio:high status:for review Waiting to be reviewd type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants