Added action tests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-1991
added
documentation
poikilotherm
approved these changes
Dec 2, 2023
Member
poikilotherm
left a comment
poikilotherm
left a comment
There was a problem hiding this comment.
Looks good to me. Just one small suggestion, as I think the Syntax fornusing the env variable in the run example is not valid.
Co-authored-by: Oliver Bertuch <[email protected]>
Member
Author
|
@poikilotherm, thank you for your feedback and for pointing out the example. Commited your proposed changes to the PR. I have also extended the outputs of the action to expose the Dataverse version. PyDataverse tests had the version hard-coded, but now with this addition, multiple versions can be tested. 🙌 |
10 tasks
Member
|
Thank you @JR-1991 for the PR, just merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET-api/info/versionGET-api/metadatablocksPOST-api/dataverses/rootREADME.mdand added tests badge✨ Successful action run