extend history retention to 8192 and modify blockhash to charge additional sload gas#4
Merged
gballet merged 15 commits intogballet:verkle-friendly-eip2935from Apr 12, 2024
Merged
Conversation
g11tech
changed the title
jsign
reviewed
Apr 12, 2024
jsign
reviewed
Apr 12, 2024
Co-authored-by: Ignacio Hagopian <[email protected]>
gballet
reviewed
Apr 12, 2024
gballet
reviewed
Apr 12, 2024
EIPS/eip-2935.md
Outdated
| ``` | ||
| // check for <=32 (<33) byte size or else revert | ||
| calldatasize | ||
| push1 0x21 |
Owner
There was a problem hiding this comment.
shouldn't we limit it to 8 bytes ?
gballet
reviewed
Apr 12, 2024
Owner
gballet
left a comment
gballet
left a comment
There was a problem hiding this comment.
left a few comments regarding the assembly
EIPS/eip-2935.md
Outdated
| Exact evm assembly that can be used for the blockhash contract: | ||
|
|
||
| ``` | ||
| // check for <=32 (<33) byte size or else revert |
Owner
There was a problem hiding this comment.
style: I'm a uppercase assemblist
gballet
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.