Skip to content

Refactor scheduler functions #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mostafa merged 4 commits into from
Dec 27, 2024
Merged

Refactor scheduler functions #649

mostafa merged 4 commits into from
Dec 27, 2024

Conversation

@mostafa
Copy link
Member

@mostafa mostafa commented Dec 27, 2024 •
edited
Loading

Ticket(s)

Fixes #460

Description

Slight refactoring of the scheduler functions.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@github-actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Overview

Image reference ghcr.io/gatewayd-io/gatewayd:1b54b7f gatewaydio/gatewayd:latest
- digest be22d4b5b3fb 383013efa302
- tag 1b54b7f latest
- provenance b6df86a
- vulnerabilities critical: 0 high: 0 medium: 1 low: 0 critical: 0 high: 1 medium: 1 low: 0
- platform linux/amd64 linux/amd64
- size 20 MB 18 MB (-2.3 MB)
- packages 144 140 (-4)
Base Image alpine:3
also known as:
• 3.20
• 3.20.3
• latest		 alpine:3.20
also known as:
• 3
• 3.20.3
• latest
- vulnerabilities critical: 0 high: 0 medium: 1 low: 0 critical: 0 high: 0 medium: 1 low: 0
Packages and Vulnerabilities (6 package changes and 1 vulnerability changes)
  • ➖ 3 packages removed
  • ♾️ 3 packages changed
  • 133 packages unchanged
  • ❗ 1 vulnerabilities added
Changes for packages of type apk (3 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:1b54b7f		 Version
gatewaydio/gatewayd:latest
➖ ca-certificates 20240705-r0
➖ openssl 3.3.2-r0
➖ pax-utils 1.3.7-r2
Changes for packages of type golang (3 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:1b54b7f		 Version
gatewaydio/gatewayd:latest
♾️ github.com/gatewayd-io/gatewayd (devel) 0.0.0-20241214123014-b6df86a6fe94
♾️ golang.org/x/net 0.33.0 0.32.0
critical: 0 high: 1 medium: 0 low: 0
Added vulnerabilities (1):
  • high : CVE--2024--45338
♾️ stdlib go1.23.4 1.23.4

@mostafa mostafa force-pushed the refactor-scheduler-functions branch from 5cc23f1 to 1b54b7f Compare December 27, 2024 23:34
@mostafa mostafa marked this pull request as ready for review December 27, 2024 23:37
@mostafa mostafa merged commit 94397ea into main Dec 27, 2024
8 of 9 checks passed
@mostafa mostafa deleted the refactor-scheduler-functions branch December 27, 2024 23:42
sinadarbouy pushed a commit that referenced this pull request Feb 18, 2025
@mostafa @sinadarbouy
Refactor scheduler functions (#649)
f8f3d86 
* Refactor health check scheduler
* Do not start metrics merger if no address is registered
* Refactor metrics merger function
* Refactor connection health check function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor scheduler functions

2 participants

@mostafa