Add Random Load Balancing Strategy #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `RANDOM` strategy in `constants.go` and `loadbalancer.go`. - Updated `gatewayd.yaml` to use the new `RANDOM` strategy as an option.
mostafa
approved these changes
Aug 9, 2024
Member
mostafa
left a comment
mostafa
left a comment
There was a problem hiding this comment.
LGTM! 🙏
Thanks for your contribution!
ccoVeille
reviewed
Aug 9, 2024
|
|
||
| proxy, err := random.NextProxy() | ||
|
|
||
| assert.Nil(t, err) |
There was a problem hiding this comment.
Suggested change
| assert.Nil(t, err) | |
| assert.NoError(t, err) |
| random := NewRandom(server) | ||
|
|
||
| assert.NotNil(t, random) | ||
| assert.Equal(t, len(proxies), len(random.proxies)) |
There was a problem hiding this comment.
Suggested change
| assert.Equal(t, len(proxies), len(random.proxies)) | |
| assert.Len(t, random.proxies, len(proxies)) |
|
|
||
| proxy, err := random.NextProxy() | ||
|
|
||
| assert.Nil(t, proxy) |
There was a problem hiding this comment.
Suggested change
| assert.Nil(t, proxy) | |
| assert.Nil(t, proxy) | |
| require.NotNil(t, err) |
Otherwise next line will panic when there is no error
I'm unsure if the gerr implents Error()
If so, I would use
Suggested change
| assert.Nil(t, proxy) | |
| assert.Nil(t, proxy) | |
| require.Error(t, err) |
Comment on lines
+57
to
+58
| proxy1, _ := random.NextProxy() | ||
| proxy2, _ := random.NextProxy() |
There was a problem hiding this comment.
Suggested change
| proxy1, _ := random.NextProxy() | |
| proxy2, _ := random.NextProxy() | |
| proxy1, err := random.NextProxy() | |
| require.NoError(t, err) | |
| proxy2, err := random.NextProxy() | |
| require.NoError(t, err) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
#398
Description
This PR introduces a new load balancing strategy, RANDOM
The key changes include
Related PRs
Development Checklist
make gen-docscommand.Legal Checklist