feat(464): add support for queueing async actions in background #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is in draft mode because it's tests need gatewayd-io/gatewayd-plugin-sdk#34 to be merged and released and can not build or run tests without it |
Member
|
@Hamsajj I update the SDK and dependencies and you need to rebase from |
Hamsajj
force-pushed
the
464
branch
2 times, most recently
from
22a4b51 to
47ce29e
Compare
mostafa
reviewed
May 29, 2024
Member
mostafa
left a comment
mostafa
left a comment
There was a problem hiding this comment.
Well done! 👏
I just left a comment about the configuration.
Add log message to see if Redis is enabled for publishing async tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
#464
Description
This is an alternative approach to this #519 which does not rely on any third-party library.
Uses Redis Pub/Sub as a backend for queuing async actions (if configured).
It will fall back to the normal goroutine if not configured to use Redis.
A consumer is added to gateway-plugin-sdk, which is used in tests to show how it can be used.
Related PRs
This PR is dependent to this one being merged and released gatewayd-io/gatewayd-plugin-sdk#34