Skip to content

Conversation

@mostafa
Copy link
Member

@mostafa mostafa commented May 23, 2024

Ticket(s)

Fixes #537.

Description

This PR address this #538 (comment) by introducing a REDIS_URL to configure the cache plugin.

@hamedsalim1999 Is this how you imagined doing this?

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa mentioned this pull request May 23, 2024
14 tasks
@mostafa mostafa self-assigned this May 23, 2024
@mostafa mostafa requested a review from hamedsalim1999 May 23, 2024 13:02
@hamedsalim1999
Copy link
Member

LGTM

@mostafa mostafa merged commit 94a747f into main May 23, 2024
@mostafa mostafa deleted the parameterize-redis-url branch May 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Docker Compose Up Fails

3 participants