Skip to content

Conversation

@mostafa
Copy link
Member

@mostafa mostafa commented May 22, 2024

Ticket(s)

Fixes #537.

Description

In this PR I tried to address the issues raised in #537:

  1. Git is now installed prior to setting the GATEWAYD_VERSION env-var.
  2. There is a new env-var, ARCH, that can be used to set the architecture of GatewayD and plugins to install and it accepts two values amd64 (default) or arm64. Otherwise it'll be set automatically using uname -m command.
  3. Improved exit codes based on this link, and added comments and logs, so that it's easier to spot the issue.

@sinadarbouy would be happy if you could test this PR and confirm that it works as expected. 🙏 Then, I'll merge it.
@hamedsalim1999 would be happy to have your feedback as well.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa marked this pull request as ready for review May 22, 2024 10:20
@sinadarbouy
Copy link
Collaborator

@mostafa I tested the PR, and it seems to be working as expected. Additionally, I can see the error(exit code) if something goes wrong, which helps in troubleshooting. Nice work!

@mostafa
Copy link
Member Author

mostafa commented May 22, 2024

@sinadarbouy Awesome! Thanks for testing it. 🙏

@mostafa mostafa merged commit adf0b21 into main May 22, 2024
@mostafa mostafa deleted the fix-setup-issues branch May 22, 2024 11:29
@mostafa mostafa self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Docker Compose Up Fails

4 participants