Skip to content

Commit 005827a

Browse files
committed
Replace 2.6-incompatible skipIf with a conditional.
- skipIf doesn't work with Python 2.6.
1 parent f60ae61 commit 005827a

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

lib/spack/spack/test/concretize.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,14 @@ def test_external_package(self):
253253
self.assertFalse('externalprereq' in spec)
254254
self.assertTrue(spec['externaltool'].compiler.satisfies('gcc'))
255255

256-
@unittest.skipIf(spack.architecture.sys_type().name == 'darwin' or
257-
spack.architecture.sys_type().name == 'linux',
258-
"No tcl modules on darwin/linux machines")
256+
259257
def test_external_package_module(self):
258+
# No tcl modules on darwin/linux machines
259+
# TODO: improved way to check for this.
260+
if (spack.architecture.sys_type().name == 'darwin' or
261+
spack.architecture.sys_type().name == 'linux'):
262+
return
263+
260264
spec = Spec('externalmodule')
261265
spec.concretize()
262266
self.assertEqual(spec['externalmodule'].external_module, 'external-module')
@@ -272,7 +276,7 @@ def test_nobuild_package(self):
272276
got_error = True
273277
self.assertTrue(got_error)
274278

275-
279+
276280
def test_external_and_virtual(self):
277281
spec = Spec('externaltest')
278282
spec.concretize()

0 commit comments

Comments
 (0)